Fixed deprecated CMake target SQLite::SQLite3 -> SQLite3::SQLite3#1484
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
trueqbit
reviewed
May 10, 2026
| @@ -1,4 +1,7 @@ | |||
| include(CMakeFindDependencyMacro) | |||
| find_dependency(SQLite3) | |||
| if(NOT TARGET SQLite3::SQLite3) # CMake < 4.3 | |||
Collaborator
There was a problem hiding this comment.
I think we don't need this in the import target cmake file. It's not sqlite_orm's responsibility to alias SQLite3 for consumers of sqlite_orm.
…Make < 4.3" This reverts commit 28334ba.
trueqbit
approved these changes
May 10, 2026
fnc12
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4.3 deprecated the
SQLite::SQLite3target name in favour ofSQLite3::SQLite3, producing dev warnings on configuration:A direct rename would break CMake < 4.3, where
SQLite3::SQLite3does not exist yet. Instead, a compatibility shim is added following the pattern recommended by CMake's own module documentation:If
SQLite3::SQLite3is not yet defined, it is aliased toSQLite::SQLite3. This keeps the build warning-free on CMake >= 4.3 while remaining fully compatible with older versions down to the project's minimum of CMake 3.16.