Add tests for some edge cases to prevent regressions#1392
Merged
llucax merged 1 commit intofrequenz-floss:v1.x.xfrom May 5, 2026
Merged
Add tests for some edge cases to prevent regressions#1392llucax merged 1 commit intofrequenz-floss:v1.x.xfrom
llucax merged 1 commit intofrequenz-floss:v1.x.xfrom
Conversation
github-actions
Bot
added
the
part:tests
simonvoelcker
previously approved these changes
Apr 23, 2026
Contributor
simonvoelcker
left a comment
simonvoelcker
left a comment
There was a problem hiding this comment.
Big fan of more tests 👍
github-project-automation
Bot
moved this from To do
to Review approved
in Python SDK Roadmap
Add targeted tests adapted to the v1.x.x branch that verify behavior for issues identified in the pull request frequenz-floss#1371: - Data sourcing: Verify duplicate subscription and unknown components with same channel name does not hang. There is also a test for invalid metrics, but this one is currently failing (it hangs), but since we plan to remove the data sourcing actor, we delay the fix for now. - Resampling: Verify invalid metric request does not block later valid request. - Power status subscriptions (battery, EV charger, PV pools): Verify same-instance subscriptions share the registry channel correctly. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Contributor
Author
simonvoelcker
approved these changes
Apr 27, 2026
github-project-automation
Bot
moved this from Review approved
to Done
in Python SDK Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add targeted tests adapted to the v1.x.x branch that verify behavior for issues identified in the pull request #1371:
Data sourcing: Verify duplicate subscription and unknown components with same channel name does not hang. There is also a test for invalid metrics, but this one is currently failing (it hangs), but since we plan to remove the data sourcing actor, we delay the fix for now.
Resampling: Verify invalid metric request does not block later valid request.
Power status subscriptions (battery, EV charger, PV pools): Verify same-instance subscriptions share the registry channel correctly.