Fix #35751: preserve Responses Lite tools after compaction - #2
Draft
fscfede-beep wants to merge 10 commits into
Draft
Fix #35751: preserve Responses Lite tools after compaction#2fscfede-beep wants to merge 10 commits into
fscfede-beep wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resumed compacted threads can lose the usable exec/code-mode tool surface when Responses WebSocket reuses a previous response and sends only an incremental suffix.
Root cause
ModelClientSession::get_incremental_items()currently treats any strict input extension as a websocket delta.CompactionandContextCompactionare context-replacement boundaries, so treating them as incremental payload items can omit the runtimeAdditionalToolsprefix rebuilt bybuild_responses_request()for Responses Lite.Proposed fix
ResponseItem::CompactionandResponseItem::ContextCompactionas a hard full-request boundary.TDD
This branch currently contains the regression tests only. RED must be established by CI before production code is added.