fix(app-server-daemon): recover live app-server from socket-owned PID - #4
Open
fscfede-beep wants to merge 25 commits into
Open
fscfede-beep wants to merge 25 commits into
fscfede-beep wants to merge 25 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focused validation patch for upstream issue openai#37893. The app-server now reports an optional processId in InitializeResponse. The daemon reads that socket-owned identity during probe and, when PID state is missing, reconstructs ownership under the existing reservation lock after validating process start time, expected Codex home, and process executable (plus exact argv on Unix). Start/restart/stop no longer leave a healthy but unmanaged server as a terminal state: start attempts safe adoption and otherwise returns an explicit safe-adoption error. Protocol fixtures are updated. A regression suite is prepared in the fork. Upstream PR creation is unavailable to the connected integration (403), and this fork PR currently has no observable CI runs, so CI is not being claimed as green.