fix(tui): detect persistent app-server version skew before resume - #8
Open
fscfede-beep wants to merge 6 commits into
Open
fix(tui): detect persistent app-server version skew before resume#8fscfede-beep wants to merge 6 commits into
fscfede-beep wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focused validation patch for upstream Codex openai#37754.
list_turnsis implemented by the local thread store, while reports show the failure when a persistent app-server is older/incompatible with the TUI. The TUI already sends its client version during initialize and RemoteAppServerClient exposes the server version returned by the handshake. This patch applies a fail-safe version guard only to LocalDaemon connections (the observed persistent-daemon skew case), rejecting a mismatch before thread/resume with an actionable daemon-restart message. Explicit Remote connections are not blocked by exact version equality. Adds pure unit coverage for equal, absent, and mismatched versions. Fork validation only; upstream mutation is unavailable through the connected integration.