fix: mathematical precision#938
Closed
cptbtptpbcptdtptp wants to merge 4 commits intogalacean:mainfrom
Closed
Conversation
Member
|
Encoding is: |
Member
|
Should fix Math unit test |
GuoLei1990
requested changes
Aug 10, 2022
| out._x = _x * len; | ||
| out._y = _y * len; | ||
| out._z = _z * len; | ||
| out._onValueChanged && out._onValueChanged(); |
Member
There was a problem hiding this comment.
Use out.set(_x * len, _y * len, _z * len); is better?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
- Coverage 28.68% 28.68% -0.01%
==========================================
Files 331 331
Lines 14323 14316 -7
Branches 2181 2180 -1
==========================================
- Hits 4109 4106 -3
- Misses 9732 9734 +2
+ Partials 482 476 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number in JS uses the IEEE754 standard: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number
IEEE754 conversion rules: https://www.h-schmidt.net/FloatConverter/IEEE754.html