Check and remove PreferNoSchedule taint from nodes after rolling update #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
reviewed/ok-to-test
gardener-robot
added
the
size/XS
ghost
added
needs/ok-to-test
takoverflow
approved these changes
Jun 10, 2025
ghost
added
the
reviewed/ok-to-test
aaronfern
force-pushed
the
forever_taint
branch
from
6b29436 to
5860537
Compare
r4mek
reviewed
Dec 9, 2025
pkg/controller/deployment_rolling.go
Outdated
| Effect: "PreferNoSchedule", | ||
| }, | ||
| ); err != nil { | ||
| klog.Warningf("Failed to remove taint %s from all nodes. Error: %s", PreferNoScheduleKey, err) |
Contributor
There was a problem hiding this comment.
Maybe we can quickly requeue the MachineDeployment in case taint removal fails.
Member
Author
There was a problem hiding this comment.
Made the requested changed as part of 8c83634
gagan16k
reviewed
Dec 9, 2025
gardener-robot
added
size/S
gardener-robot
added
size/M
gardener-robot
added
size/XL
gardener-robot
added
reviewed/lgtm
r4mek
approved these changes
Dec 15, 2025
gagan16k
approved these changes
Dec 15, 2025
gardener-robot
added
the
status/closed
thiyyakat
pushed a commit
to thiyyakat/machine-controller-manager
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We sometimes have a case where the
PreferNoScheduletaint can remain indefinitely on nodes if we backtrack on a rolling updateThis PR adds a check to remove this taint from nodes after a rolling update is complete
Which issue(s) this PR fixes:
Fixes #989
Special notes for your reviewer:
Release note: