fix: ad-hoc codesign compiled binaries on Apple Silicon after build#1003
Open
voidborne-d wants to merge 1 commit intogarrytan:mainfrom
Open
fix: ad-hoc codesign compiled binaries on Apple Silicon after build#1003voidborne-d wants to merge 1 commit intogarrytan:mainfrom
voidborne-d wants to merge 1 commit intogarrytan:mainfrom
Conversation
On some Apple Silicon machines, Bun's --compile produces a corrupt or linker-only code signature. macOS kills these binaries with SIGKILL (exit 137, zsh: killed) before they execute a single instruction. Add a post-build codesign step to setup that runs only on Darwin arm64: 1. Remove the corrupt/linker-only signature (required — a direct re-sign fails with 'invalid or unsupported format for signature') 2. Apply a fresh ad-hoc signature The step is idempotent, costs <1s, and is what Bun's own docs recommend for distributed standalone executables. All four compiled binaries are covered: browse, find-browse, design, and gstack-global-discover. Failure is a non-fatal warning so Intel/CI builds are unaffected. Fixes garrytan#997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On some Apple Silicon machines,
bun build --compileproduces a corrupt or linker-only code signature. macOS kills these binaries with SIGKILL (exit 137,zsh: killed) before they execute a single instruction. Every re-run of./setupreproduces the same unrunnable binary.The root cause is well-documented upstream (Bun #7208, Go #42684): Apple Silicon requires properly signed executables, and linker-signed-only binaries get killed. A naive
codesign -s - -falso fails because the existing (broken) signature block prevents re-signing.Fix
Add a post-build codesign step to
setupthat runs only on Darwin arm64:codesign --remove-signature) — this is required because a direct re-sign fails with "invalid or unsupported format for signature"codesign -s - -f)All four compiled binaries are covered:
browse/dist/browsebrowse/dist/find-browsedesign/dist/designbin/gstack-global-discoverProperties
Darwin+arm64Tests
Added
test/setup-codesign.test.ts(6 tests):Fixes #997