fix: support documented generic setup hosts#1004
Open
sahaavi wants to merge 1 commit intogarrytan:mainfrom
Open
fix: support documented generic setup hosts#1004sahaavi wants to merge 1 commit intogarrytan:mainfrom
sahaavi wants to merge 1 commit intogarrytan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This finishes setup support for the documented generic hosts that already exist in the host registry but were still rejected by ./setup.
Before this change:
Root cause
setup still had a hardcoded host allowlist and install flow, while host registration had already moved into the declarative host config system.
What changed
Verification
Passed:
Manual smoke:
Notes
I also confirmed that stale golden baselines in the current checkout are unrelated to this change, so I kept this PR focused on the setup/host-config gap only.