test(guardian): add public publishing decision snapshots - #1533
Open
sentry-junior[bot] wants to merge 7 commits into
Open
test(guardian): add public publishing decision snapshots#1533sentry-junior[bot] wants to merge 7 commits into
sentry-junior[bot] wants to merge 7 commits into
Conversation
Guardian was treating public issue/PR title and body updates as private organization data exfiltration when the text merely mentioned internal systems. That blocked user-confirmed, non-secret product tracking writes. Clarify the Data Exfiltration policy so secrets and private customer data still deny, while sanitized public GitHub metadata is ordinary work after explicit user authorization. Add Guardian snapshot cases for the allow and deny boundaries. Evidence: https://sentry.slack.com/archives/C0B595QDZLL/p1786642920488239 Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Add a Guardian snapshot for ordinary code-change work that ends in a non-secret draft pull request, and mark that path as ordinary medium-risk work so public destination alone does not force another confirmation. Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
marked this pull request as ready for review
August 13, 2026 19:41
dcramer
reviewed
Aug 13, 2026
Make the allow cases look like the internal over-deny: user-confirmed public GitHub writes that still mention internal systems. Drop the draft special case for ordinary PR creation, and keep absolute deny cases for secrets and private customer data.
dcramer
added a commit
that referenced
this pull request
Aug 14, 2026
Guardian evals already computed pass rate text, but the PR checklist only showed GitHub's canned job line (`failing after 2m`) because we never published a dedicated Check Run. Mirror the behavioral eval reporter path: - grant `checks: write` - soft-fail the run step, hard-fail if results are missing - publish `guardian / score` with `fail-on-failures: true` so the checklist secondary line shows pass-rate title text (for example `Eval pass rate 94.4% — required 100.0%`) Evidence: #1533 <!-- junior-request-attribution:start --> Requested by **David Cramer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0B595QDZLL%3A1786653013.935559 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0B595QDZLL%3A1786653013.935559) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0B595QDZLL%3A1786653013.935559/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: David Cramer <david@sentry.io>
Add a synthetic baseline case for public GitHub comment disclosure of customer commercial data after a ticket lookup, including ambient ticket-creation thread context that must not authorize the write. Co-Authored-By: David Cramer <david@sentry.io>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5a73f25. Configure here.
Production bash has no describeProposal, so Guardian never sees a proposalDescription for shell commands. Remove the editorial coaching text from the customer-comment deny fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Guardian decision snapshots for public GitHub publishing boundaries. This is the failing baseline for a TDD pass. Policy is intentionally unchanged.
Cases
Notes
The cases use neutral fixtures. They do not copy one incident transcript.
Verification
git diff --checkpass.Requested by David Cramer.
--
View Junior Session [Sentry]