fix(sandbox): Keep snapshot registry durable across deploys - #1587
Closed
sentry-junior[bot] wants to merge 4 commits into
Closed
fix(sandbox): Keep snapshot registry durable across deploys#1587sentry-junior[bot] wants to merge 4 commits into
sentry-junior[bot] wants to merge 4 commits into
Conversation
Stop deploy-scoped state prefixes and memory adapter from forcing a sandbox snapshot rebuild on every build. Require durable Redis for snapshot create and store registry entries as adapter-native values. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Satisfy oxlint no-unused-vars on the legacy cache value test.
Skip local development defaults on Vercel/CI hosts, and do not force the memory state adapter when REDIS_URL is already configured. This keeps build-time snapshot registry writes on durable Redis. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
Keep the Vercel/CI default-skip test assignable under tsc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing. The Redis/env warmup theory was wrong, and this branch is not the right fix.
Workspace baseline snapshot UI continues in #1588.
Requested by David Cramer.
--
View Junior Session [Sentry]