feat(mobile): Backfill app.vitals.start.screen to mobile v1 transactions#5960
Open
feat(mobile): Backfill app.vitals.start.screen to mobile v1 transactions#5960
app.vitals.start.screen to mobile v1 transactions#5960Conversation
buenaflor
commented
May 7, 2026
buenaflor
force-pushed
the
backfill-app-vitals-start-screen
branch
from
d0e8c78 to
0f8d798
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a normalization/backfill step for mobile transactions to populate app.vitals.start.screen on existing ui.load transactions when app start measurements are present, preserving backward compatibility during the schema transition.
Changes:
- Extend app-start measurement source detection to include both legacy (
app_start_*) andapp.vitals.start.*-style measurement keys. - Add
backfill_app_vitals_start_screento writeapp.vitals.start.screenintocontexts.trace.datafor qualifyingui.loadtransactions. - Add unit tests covering the new screen backfill behavior and guard conditions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
loewenheim
requested changes
May 8, 2026
buenaflor
force-pushed
the
backfill-app-vitals-start-screen
branch
from
3141cf6 to
71ca2ea
Compare
buenaflor
force-pushed
the
backfill-app-vitals-start-screen
branch
from
71ca2ea to
d4fa6e5
Compare
Contributor
|
Am I correct in assuming that this is a non-concern for span V2 because everything will already be sent correctly? |
loewenheim
approved these changes
May 11, 2026
Contributor
Author
|
Yes, v2 spans already send the correct data so no need to backfill there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mobile we are implementing a new schema on how we send app start data and in order to be backwards compatible we need to backfill
app.vitals.start.screento existingui.loadtransactions that have app start measurements