fix(schema): Implement remove other for enums#5962
Open
Conversation
Dav1dde
force-pushed
the
dav1d/impl-remove-other-for-enums
branch
from
0e1ef81 to
a01284d
Compare
Dav1dde
force-pushed
the
dav1d/impl-remove-other-for-enums
branch
from
a01284d to
d2f8127
Compare
loewenheim
approved these changes
May 8, 2026
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
Is there more to do? So far this looks extremely reasonable.
Member
Author
|
@loewenheim put it back in draft because I realized Annotated all uses of |
loewenheim
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently this was never implemented for
ProcessValue, I think I am calling the rightenter/exitfunctions, but would appreciated a second set of eyes and thoughts whether this is actually correct.One big side-track trying to implement #5280