Support charset in decode_data_url
#137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
dataurl-charset
branch
from
bfce02c to
daee1d8
Compare
coolreader18
force-pushed
the
dataurl-charset
branch
from
daee1d8 to
0e73647
Compare
loewenheim
approved these changes
Dec 6, 2025
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Contributor
Author
|
Would it be possible to cut a release with this patch in it? |
Contributor
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rolldown's sourcemap implementation outputs inline source maps that start withdata:application/json;charset=utf-8;base64,, which would currently fail with the implementation ofdecode_data_url. Obviously, this seems like a slippery slope to implementing the entirety of the mime type spec, but hopefully this is about the extent of the variance in most common sourcemap generators.Github code search for
data:application/json;charset=utf-8Github code search for
data:application/json;charset=utf8