fix: Various fixes (v2 backport)#3309
Merged
Merged
Conversation
Fixes [SDK-1193](https://linear.app/getsentry/issue/SDK-1193/sentry-cli-fix-bash-hook-shell-injection) #skip-changelog
Only disable SSL verification when the relevant field is defined in the config and case-insensitively equal to `"false"`. Previously, SSL verification was disabled whenever the option was set, but not case-sensitively equal to `"true"`, which could lead to the case where users who set the option to `"True"` having SSL verification unintentionally disabled. #skip-changelog Fixes [SDK-1238](https://linear.app/getsentry/issue/SDK-1238/sentry-cli-strict-string-comparison-for-ssl-verify-setting-silently)
In hindsight, not sure this change is worth the added complexity. But I suppose it is a bit safer if we check the checksums after download. For this backport commit, we also need to add `sha2` to our dependencies; it does not exist in `v2` yet. #skip-changelog Fixes [SDK-1235](https://linear.app/getsentry/issue/SDK-1235/sentry-cli-self-update-binary-downloaded-without-integrity)
Ensure config files have the correct permissions, even when overwriting an existing file, by first creating them as a brand new temporary file, then atomically renaming them over any exisiting file. Fixes [SDK-1234](https://linear.app/getsentry/issue/SDK-1234/sentry-cli-config-file-permissions-not-enforced-on-pre-existing-files)
loewenheim
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3308 to
v2Contains the following commits, which correspond to PRs from a private repo:
244d5a0: changelog update3e389f0: https://github.com/getsentry/sentry-cli-security-fixes/pull/135878120: https://github.com/getsentry/sentry-cli-security-fixes/pull/224f410a6: https://github.com/getsentry/sentry-cli-security-fixes/pull/1855c52fb: https://github.com/getsentry/sentry-cli-security-fixes/pull/19578acff: https://github.com/getsentry/sentry-cli-security-fixes/pull/2118484cf: https://github.com/getsentry/sentry-cli-security-fixes/pull/11#skip-changelog