Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
mydea
added this pull request to stack #19507
September 18, 2026 10:24
6 tasks
mydea
marked this pull request as ready for review
September 18, 2026 10:47
mydea
force-pushed
the
guide-cat/03-fix-serverless-runtimes
branch
from
September 18, 2026 10:49
2354f4b to
c5d9b2a
Compare
chargome
approved these changes
Sep 21, 2026
Node, Bun, and Deno are long-running server runtimes, not serverless/FaaS platforms, so the `serverless` category was semantically wrong for them. The genuinely serverless guides (aws-lambda, azure-functions, gcp-functions, cloudflare, and firebase/Cloud Functions) keep it. No rendered content changes: `serverless` is always paired with `server` in every section/option/link filter (which these guides retain), and the only filters that key on `serverless` alone are migration items that are also gated by `frameworks: [aws-lambda|cloudflare]`, so they never applied to node/bun/deno regardless. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
guide-cat/03-fix-serverless-runtimes
branch
from
September 21, 2026 08:06
c5d9b2a to
ae504b8
Compare
mydea
added a commit
that referenced
this pull request
Sep 21, 2026
## DESCRIBE YOUR PR > **Stacked PR.** Part of the JavaScript guide-categories series (#19492 → #19506). Depends on #19494; review/merge bottom-up. Extract the repeated `categories.includes('server') || includes('serverless')` logic into shared `hasServerCategory` / `hasBrowserCategory` helpers (`src/categories.ts`) and use them in `sdkOption` and `platformLink`. - Behavior-preserving cleanup; no rendered output changes. - The `nextjs`/`sveltekit` env-var exclusion in `shouldShowEnvVar` is intentionally left as a framework-specific special case. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. Select exactly one option. For deadlines, replace `YYYY-MM-DD` with the due date. You can update this information later by editing the PR description. - [ ] Urgent deadline (GA date, etc.): YYYY-MM-DD - [ ] Other deadline: YYYY-MM-DD - [x] No deadline: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've supplied a deadline. Thanks in advance for your help! ## PRE-MERGE CHECKLIST _Make sure you've checked the following before merging your changes:_ - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Node, Bun, and Deno are long-running server runtimes, not serverless/FaaS platforms, so the
serverlesscategory was semantically wrong for them.serverlessis always paired withserverin every filter these guides retain, and the onlyserverless-alone consumers (migration items) are also gated byframeworks:.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code