Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
mydea
added this pull request to stack #19507
September 18, 2026 10:24
6 tasks
mydea
force-pushed
the
guide-cat/14-crons-mcp-queues
branch
from
September 18, 2026 10:50
cb5a535 to
fea6bff
Compare
mydea
marked this pull request as ready for review
September 18, 2026 11:10
Comment on lines
+6
to
+7
| supportedCategories: | ||
| - server |
Contributor
There was a problem hiding this comment.
Bug: Using supportedCategories: [server] hides documentation from platforms like AWS Lambda because their configs lack a categories field, causing the isSupported check to fail.
Severity: HIGH
Suggested Fix
To fix this, add the categories: [server] property to the config.yml files for all relevant serverless platforms (e.g., aws-lambda, azure-functions, gcp-functions). Alternatively, revert the front matter filtering on the affected pages to use the previous explicit supported list, or modify the isSupported function to handle missing categories.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/platforms/javascript/common/crons/troubleshooting.mdx#L6-L7
Potential issue: The change from an explicit `supported` list to `supportedCategories:
[server]` in the front matter of documentation pages introduces a bug. The `isSupported`
function in `frontmatter.ts` now checks if a platform's `categories` array includes
`'server'`. However, serverless platforms like `aws-lambda`, `azure-functions`, and
`gcp-functions` do not have a `categories` field defined in their `config.yml`. As a
result, the check fails, and these platforms are incorrectly excluded from seeing
relevant documentation pages, such as the crons documentation, despite being listed in
`<PlatformSection>` components on the page.
Also affects:
docs/platforms/javascript/common/crons/index.mdx:7~8
Did we get this right? 👍 / 👎 to inform future reviews.
chargome
approved these changes
Sep 21, 2026
mydea
force-pushed
the
guide-cat/14-crons-mcp-queues
branch
from
September 21, 2026 08:07
fea6bff to
8c5d717
Compare
mydea
force-pushed
the
guide-cat/14-crons-mcp-queues
branch
from
September 21, 2026 08:18
8c5d717 to
ede02ec
Compare
mydea
force-pushed
the
guide-cat/14-crons-mcp-queues
branch
from
September 21, 2026 08:30
ede02ec to
c41c053
Compare
…ages Replace the enumerated server-framework `supported` lists on crons/*, mcp-monitoring, and the queues/caches instrumentation pages with `supportedCategories: [server]`. These already listed all edge runtimes (cloudflare/deno/bun); the category form additionally covers the guides that were stale-omitted from the manual lists (effect, elysia, firebase, mastra, nitro, and some meta-frameworks). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
guide-cat/14-crons-mcp-queues
branch
from
September 21, 2026 09:04
c41c053 to
507baee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Replace the enumerated server-framework
supportedlists on crons/*, mcp-monitoring, and the queues/caches instrumentation pages withsupportedCategories: [server].wrapMcpServerWithSentrylives in@sentry/coreand is runtime-agnostic, so[server]is accurate.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code