-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Add ignoreSentryInternalFrames option to thirdPartyErrorFilterIntegration
#18632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add ignoreSentryInternalFrames option to thirdPartyErrorFilterIntegration
#18632
Conversation
thirdPartyErrorFilterIntegrationexperimentalExcludeSentryInternalFrames option to thirdPartyErrorFilterIntegration
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
|
It makes sense to not alter existing behaviour in the major but if this proves to be valuable, perhaps it should become default behaviour in the next major? |
|
I renamed the option to exclude the |
experimentalExcludeSentryInternalFrames option to thirdPartyErrorFilterIntegrationignoreSentryInternalFrames option to thirdPartyErrorFilterIntegration
Some users get flooded by third party errors despite having set their third party error filtering to
"drop-error-if-contains-third-party-frames". This comes from the fact that often the stacktrace includes our internal wrapper logic as last trace in the stack.With this PR we're trying to work around this by specifically ignoring these frames with a new opt-in mechanism. Marked this as experimental, so users will know this option might lead to errors being misclassified.
experimentalExcludeSentryInternalFramesto thethirdPartyErrorFilterIntegrationCloses #13835