Skip to content

Conversation

@chargome
Copy link
Member

With this PR we emit a warning for client, node and edge whenever the user sets debug: true in init but at the same time treeshakes logging statements using webpack.

This will not emit anything for turbopack.

closes https://linear.app/getsentry/issue/FE-610/warn-at-build-time-for-conflicting-disablelogger-and-debug-settings-in

@chargome chargome requested a review from logaretm December 30, 2025 11:27
@chargome chargome self-assigned this Dec 30, 2025
@linear
Copy link

linear bot commented Dec 30, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.84 kB - -
@sentry/browser - with treeshaking flags 23.34 kB - -
@sentry/browser (incl. Tracing) 41.62 kB - -
@sentry/browser (incl. Tracing, Profiling) 46.21 kB - -
@sentry/browser (incl. Tracing, Replay) 80.19 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.93 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84.87 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 97.12 kB - -
@sentry/browser (incl. Feedback) 41.56 kB - -
@sentry/browser (incl. sendFeedback) 29.53 kB - -
@sentry/browser (incl. FeedbackAsync) 34.52 kB - -
@sentry/browser (incl. Metrics) 25.87 kB - -
@sentry/browser (incl. Logs) 26.09 kB - -
@sentry/browser (incl. Metrics & Logs) 26.75 kB - -
@sentry/react 26.56 kB - -
@sentry/react (incl. Tracing) 43.81 kB +0.01% +4 B 🔺
@sentry/vue 29.3 kB - -
@sentry/vue (incl. Tracing) 43.43 kB - -
@sentry/svelte 24.85 kB - -
CDN Bundle 27.27 kB - -
CDN Bundle (incl. Tracing) 42.26 kB - -
CDN Bundle (incl. Tracing, Replay) 78.97 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 84.42 kB - -
CDN Bundle - uncompressed 80.08 kB - -
CDN Bundle (incl. Tracing) - uncompressed 125.51 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 242.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 254.81 kB - -
@sentry/nextjs (client) 46.17 kB +0.29% +130 B 🔺
@sentry/sveltekit (client) 41.99 kB - -
@sentry/node-core 51.66 kB - -
@sentry/node 161.55 kB - -
@sentry/node - without tracing 93.09 kB - -
@sentry/aws-serverless 108.6 kB - -

View base workflow run

Copy link
Collaborator

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@chargome chargome merged commit da1c41f into develop Dec 30, 2025
69 checks passed
@chargome chargome deleted the cg/FE-610/warn-at-build-time-for-conflicting-disablelogger-and-debug-settings-in branch December 30, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants