test(e2e): Port the nestjs-distributed-tracing E2E app to span streaming - #24108
Merged
Conversation
Removes the `traceLifecycle: 'static'` pin and rewrites the specs against streamed spans. Streamed spans carry neither scope tags nor breadcrumbs, so the event-handler specs have the app report its isolation scope as span attributes, the same way the Next.js middleware specs do. Ref: #23801 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
…wrapper The local `waitForSegmentSpan` only re-expressed what `waitForStreamedSpan` already does, and was copied into every ported app. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 62fb4b6. Configure here.
…racing helper Streamed spans do carry scope user, attributes and contexts; only tags and breadcrumbs never reach them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
chargome
marked this pull request as ready for review
September 7, 2026 12:48
Switches the span assertions from `toMatchObject` to `toEqual` so an unexpected field fails the test. These are all segment spans, whose attributes include the scope contexts and SDK integration list, so the attribute matching stays partial. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Lms24
approved these changes
Sep 9, 2026
| end_timestamp: expect.any(Number), | ||
| is_segment: true, | ||
| attributes: expect.objectContaining({ | ||
| 'sentry.origin': { type: 'string', value: 'auto.http.http_server' }, |
Member
There was a problem hiding this comment.
l: looks like this test misses a few attributes we previously had on the transaction test
| end_timestamp: expect.any(Number), | ||
| is_segment: true, | ||
| attributes: expect.objectContaining({ | ||
| 'sentry.origin': { type: 'string', value: 'auto.http.http_server' }, |
…to assert The port narrowed the segment span assertions to a handful of attributes. This pins the same set the transaction-based specs did - transport, client, network and request headers - now grouped in helpers rather than repeated four times. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceLifecycle: 'static'pin and rewrites the specs against streamed spans.Streamed spans carry neither scope tags nor breadcrumbs, so the event-handler specs have the app report its isolation scope as span attributes, the same way the Next.js middleware specs do.
Ref: #23801
🤖 Generated with Claude Code