Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| Debug.Log("Sentry: IntegrationOptionsConfig::Configure() called"); | ||
|
|
||
| // DSN is read from SentryOptions.asset (baked at build time via configure-sentry.ps1) | ||
| // No custom DSN override needed -- the real DSN is set in the editor configuration. |
There was a problem hiding this comment.
DSN never baked into asset, Sentry disabled at runtime
High Severity
IntegrationOptionsConfiguration.Configure() never sets options.Dsn, and the comment claims it's "read from SentryOptions.asset (baked at build time via configure-sentry.ps1)." However, configure-sentry.ps1 and its ConfigureOptions Unity method don't write the DSN to the asset. The SENTRY_DSN env var set in the workflow step is never consumed by any code. Since the project is created fresh in CI, SentryOptions.asset will have a null DSN, and the Unity SDK's IsValid check will disable Sentry entirely at runtime—causing all integration tests to silently fail.
Additional Locations (1)
|
|
||
| BeforeAll { | ||
| $script:AndroidComponent = "io.sentry.unity.integrationtest/com.unity3d.player.UnityPlayerActivity" | ||
| $script:FallbackAndroidComponent = "io.sentry.unity.integrationtest/com.unity3d.player.UnityPlayerGameActivity" |
There was a problem hiding this comment.
Unused $FallbackAndroidComponent variable defined but never referenced
Low Severity
$script:FallbackAndroidComponent is defined in BeforeAll but is never referenced anywhere in the file or codebase. Only $script:AndroidComponent is actually passed to Invoke-DeviceApp. This is dead code that adds confusion about whether a fallback mechanism was intended but not implemented.
1 participant
#skip-changelog