ref(core): consolidate button styles files and remove chonk naming

[JonasBa]

Summary

Consolidates button/styles.chonk.tsx into button/styles.tsx and removes chonk naming prefixes.

Changes

• Moved all content from styles.chonk.tsx to styles.tsx
• Renamed functions and types:
  • ChonkButtonType → ButtonType
  • chonkPriorityToType → priorityToType
  • chonkElevation → elevation
  • chonkHoverElevation → hoverElevation
  • getChonkButtonTheme → getButtonTheme
  • getChonkButtonSizeTheme → getButtonSizeTheme
• Updated imports in:
  • button.tsx
  • linkButton.tsx
  • segmentedControl.chonk.tsx
• Deleted styles.chonk.tsx

Test plan

• ✅ Linting passes
• ✅ Knip passes (no unused exports)
• ✅ No remaining chonk references (except external dependencies and intentional DO_NOT_USE naming)

[natemoo-re]

LGTM other than the DO_NOT_USE_getChonkButtonStyles function!

[sentry]

Bug: The call to DO_NOT_USE_getButtonStyles is missing the required busy and borderless properties, which will cause a TypeScript compilation error.
_{Severity: HIGH | Confidence: High}

🔍 Detailed Analysis

The call to the function DO_NOT_USE_getButtonStyles within segmentedControl.chonk.tsx does not match its expected signature. The function's parameter type requires busy and borderless properties, but the current implementation fails to provide them. The object passed to the function is constructed by spreading props p, which do not contain these required keys. This discrepancy will result in a TypeScript compilation error, preventing the code from being built successfully.

💡 Suggested Fix

Update the object passed to DO_NOT_USE_getButtonStyles to include the missing required properties. You should add default values for busy and borderless to the object literal to satisfy the function's type signature.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/components/core/segmentedControl/segmentedControl.chonk.tsx#L78-L81

Potential issue: The call to the function `DO_NOT_USE_getButtonStyles` within
`segmentedControl.chonk.tsx` does not match its expected signature. The function's
parameter type requires `busy` and `borderless` properties, but the current
implementation fails to provide them. The object passed to the function is constructed
by spreading props `p`, which do not contain these required keys. This discrepancy will
result in a TypeScript compilation error, preventing the code from being built
successfully.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8191511}