-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(deps): bump qs from 6.13.1 to 6.14.1 in /api-docs #105590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bumps [qs](https://github.com/ljharb/qs) from 6.13.1 to 6.14.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.13.1...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
| resolution: {integrity: sha512-RHxMLp9lnKHGHRng9QFhRCMbYAcVpn69smSGcq3f36xjgVVWThj4qqLbTLlq7Ssj8B+fIQ1EuCEGI2lKsyQeIw==} | ||
|
|
||
| [email protected].1: | ||
| resolution: {integrity: sha512-okMH7OXXJ7YrN9Ok3/SXrnu4iX9yOk+25nqX4imS2npuvTYDmo/QEZoqwZkYaIDk3jVvBOTOIEgEhaLOynBS9g==} | ||
| [email protected].2: | ||
| resolution: {integrity: sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==} | ||
| hasBin: true | ||
|
|
||
| [email protected].0: | ||
| resolution: {integrity: sha512-wpxZs9NoxZaJESJGIZTyDEaYpl0FKSA+FB9aJiyemKhMwkxQg63h4T1KJgUGHpTqPDNRcmmYLugrRjJlBtWvRA==} | ||
| [email protected].1: | ||
| resolution: {integrity: sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==} | ||
| hasBin: true | ||
|
|
||
| [email protected]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The PR claims to bump the qs package for a security fix, but the lockfile changes do not actually apply this update.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The pull request's title and description state an intent to bump the qs package from version 6.13.1 to 6.14.1. This update is noted to contain a critical security fix. However, the actual changes within the api-docs/pnpm-lock.yaml file do not include this version bump for qs. While the lockfile is internally consistent and will not cause a runtime crash, it fails to incorporate the intended security patch, leaving the dependency at the older, vulnerable version.
💡 Suggested Fix
Regenerate the lockfile to correctly bump the qs package from version 6.13.1 to 6.14.1 as stated in the pull request's description. Ensure that the pnpm-lock.yaml reflects the updated version and its resolved dependencies.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: api-docs/pnpm-lock.yaml#L331-L342
Potential issue: The pull request's title and description state an intent to bump the
`qs` package from version 6.13.1 to 6.14.1. This update is noted to contain a critical
security fix. However, the actual changes within the `api-docs/pnpm-lock.yaml` file do
not include this version bump for `qs`. While the lockfile is internally consistent and
will not cause a runtime crash, it fails to incorporate the intended security patch,
leaving the dependency at the older, vulnerable version.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8091481
Bumps qs from 6.13.1 to 6.14.1.
Changelog
Sourced from qs's changelog.
Commits
3fa11a5v6.14.1a626704[Dev Deps] updatenpmignore3086902[Fix] ensure arrayLength applies to[]notation as wellfc7930e[Dev Deps] updateeslint,@ljharb/eslint-config0b06aac[Dev Deps] update@ljharb/eslint-config64951f6[Refactor]parse: extract key segment splitting helpere1bd259[Dev Deps] update@ljharb/eslint-configf4b3d39[eslint] add eslint 9 optional peer dep6e94d95[Dev Deps] updateeslint,@ljharb/eslint-config,npmignore973dc3c[actions] add workflow permissionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.