-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
WIP: add request console sdk access button component #105599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
…alexsohn/feat/add-request-console-sdk-access-button-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moved to static/app/components/gameConsole/RequestSdkAccessButton.tsx now
| @@ -1,5 +1,5 @@ | |||
| type GamingPlatformBase = { | |||
| origin: 'onboarding' | 'project-creation' | 'project-settings'; | |||
| origin: 'onboarding' | 'project-creation' | 'project-settings' | 'org-settings'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org-settings was added because of a new page that will be created in a different PR:
…alexsohn/feat/add-request-console-sdk-access-button-component
…alexsohn/feat/add-request-console-sdk-access-button-component
Previously,
RequestAccessButtoncomponent which opens the console SDK invite modal was only used in tempest related pages.This PR aims to consolidate all of those buttons to use the same button component, which will make it easier to make changes in the future, and it also allows us to use the useReopenGamingSdkModal hook which will re-open the console sdk invite modal if they went through the GitHub account linking pipeline