feat: Extend performance profiles to V2 spans#115203
Merged
Merged
Conversation
This makes performance profiles able to also match V2 spans by turning the browser name conditions into disjunctions checking two different fields. This is required to enable performance score calculation for V2 spans.
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c624d67. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
commented
May 8, 2026
| }, | ||
| ], | ||
| }, | ||
| "condition": _browser_name_one_of("Chrome", "Google Chrome"), |
Contributor
Author
There was a problem hiding this comment.
This case is the only reason the function takes multiple arguments to begin with.
jjbayer
approved these changes
May 11, 2026
dashed
pushed a commit
that referenced
this pull request
May 11, 2026
This makes performance profiles able to also match V2 spans by turning the browser name conditions into disjunctions checking two different fields. This is required to enable performance score calculation for V2 spans. This is a companion PR to getsentry/relay#5947. That PR contains some test cases showing that profiles with these expanded conditions work for V2 spans. Closes INGEST-895.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes performance profiles able to also match V2 spans by turning the browser name conditions into disjunctions checking two different fields.
This is required to enable performance score calculation for V2 spans.
This is a companion PR to getsentry/relay#5947. That PR contains some test cases showing that profiles with these expanded conditions work for V2 spans.
Closes INGEST-895.