chore(dynamic-sampling): cleanup transaction based health check rule#115471
chore(dynamic-sampling): cleanup transaction based health check rule#115471shellmayr wants to merge 1 commit into
Conversation
shellmayr
commented
May 13, 2026
- We've dialed in the new trace based health check bias to end up roughly with the same volume as the previous transaction based ruleset
- Clean up the rule & all associated artifacts
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9094659. Configure here.
| {"id": RuleType.BOOST_REPLAY_ID_RULE.value, "active": False}, | ||
| ], | ||
| ) | ||
|
|
There was a problem hiding this comment.
Test expects old transaction factor instead of trace factor
Medium Severity
The test_generate_rules_minimum_sample_rate_correct_order test asserts that the health check rule value equals 0.4 / 5, based on the old IGNORE_HEALTH_CHECKS_FACTOR_TRANSACTIONS. After this PR, the system always uses IgnoreHealthChecksTraceBias, which divides by IGNORE_HEALTH_CHECKS_FACTOR_TRACES = 3. The actual value will be 0.4 / 3, causing this test to fail.
Reviewed by Cursor Bugbot for commit 9094659. Configure here.
Backend Test FailuresFailures on
|

