theme(feat[sidebar]): Add django-search-query project link#67
Merged
Conversation
why: django-search-query and its admin companion package were missing from the sidebar project roster. Adding the sub-package link exposed a detection gap: a bare-host link and a same-host sub-path link both matched, so the parent and child lit up together. what: - Add django-search-query with an (admin) sub-link to the django group - Mark only the deepest matching link active in sidebar detection, so agentgrep/(mcp) and libtmux/(pytest) also resolve to one entry - Mirror the template into the docs/_templates override
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 273 273
Lines 21520 21520
=======================================
Hits 19939 19939
Misses 1581 1581 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
why: Record the user-visible sidebar highlighting change for the forthcoming release. what: - Add a Fixes entry under the unreleased heading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
django-search-queryto the sidebar project roster, with its companion package linked as(admin)following the existing(cli)/(db)/(mcp)idiom for satellite packages.Adding that sub-link surfaced a gap in the sidebar's active-link detection. Links without a path match on hostname alone; links with a path match on prefix. On
https://django-search-query.git-pull.com/packages/django-admin-search-query/both rules fire, so the parent and the child were marked active at once. The same applied toagentgrep/(mcp)andlibtmux/(pytest).Detection now keeps only the deepest matching path, so the most specific link wins:
django-search-query.git-pull.com/packages/django-admin-search-query/django-search-query+adminadminagentgrep.org/mcp/agentgrep+mcpmcplibtmux.git-pull.com/pytest-plugin/libtmux+pytestpytest/admin/on that host returns 403;/packages/django-admin-search-query/is the live path and is what the link targets.The template ships in
sphinx-gp-themeand is shadowed byte-for-byte by gp-sphinx's owndocs/_templatesoverride, so both copies carry the change.Verified with
ruff,mypy, the full pytest suite, andjust build-docs.