Skip to content

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Jan 10, 2026

No description provided.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jan 10, 2026
@github-actions github-actions bot added the C++ label Jan 10, 2026
@jketema jketema marked this pull request as ready for review January 10, 2026 16:31
@jketema jketema requested a review from a team as a code owner January 10, 2026 16:31
Copilot AI review requested due to automatic review settings January 10, 2026 16:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates test expectations for C++ friend declaration analysis following changes to the C++ extractor. The extractor now detects additional template friend relationships that were previously not captured.

Changes:

  • Updated test expectations to include newly detected friend relationships for template classes with E<T> and F<T> instantiations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jketema jketema merged commit 5d00a4d into github:main Jan 14, 2026
11 of 12 checks passed
@jketema jketema deleted the jketema/friends branch January 14, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants