[code-simplifier] refactor: simplify generateCustomJobToolDefinition and extractDispatchWorkflowNames

[github-actions]

This PR simplifies two functions added or moved in recent PRs (#20080, #19965), applying Go best practices and project conventions for clarity.

Files Simplified

• pkg/workflow/safe_outputs_config_generation.go — Simplified generateCustomJobToolDefinition (moved from safe_outputs_generation.go in IMP-003: Move generateCustomJobToolDefinition to safe_outputs_config_generation.go #20080)
• pkg/cli/remote_workflow.go — Simplified extractDispatchWorkflowNames (added in feat(add): fetch dispatch-workflow dependencies and resources when adding remote workflows #19965)

Improvements Made

generateCustomJobToolDefinition

1. Removed unnecessary guard — if len(jobConfig.Inputs) > 0 { ... } is not needed; ranging over a nil/empty map is a safe no-op in Go. Removing it reduces nesting by one level.

2. Merged duplicate switch cases — case "string", "": and default: both set property["type"] = "string". Merged into a single default: with a clearer comment.

3. Inlined additionalProperties: false into the map literal where the schema is initialised, keeping all schema defaults together.

4. Return the tool map at the point of return instead of building it at the top and mutating it through the function — clearer data flow.

5. Removed obvious inline comments that restate what the code already expresses (e.g. // Build the tool definition, // Track required fields, // Add description if present), per project style: "Only comment code that needs a bit of clarification."

extractDispatchWorkflowNames

1. Combined two-step existence + type assertion for safe-outputs into a single comma-ok type assertion (nil map key returns nil, false in comma-ok form).

2. Inlined the filter into the collection loops — the separate post-collection filter loop is eliminated by adding !strings.Contains(name, "$\{\{") to the guard inside each case branch.

3. Simplified nested existence + type assertion for v["workflows"] into a direct comma-ok type assertion, removing a level of nesting.

Testing

• ✅ All targeted tests pass (TestGenerateCustomJobToolDefinition*, TestExtractDispatchWorkflowNames_*)
• ✅ Full unit test suite passes (make test-unit)
• ✅ Build succeeds (make build)
• ✅ No functional changes — behaviour is identical

Changes Based On

• IMP-003: Move generateCustomJobToolDefinition to safe_outputs_config_generation.go #20080 — moved generateCustomJobToolDefinition to safe_outputs_config_generation.go
• feat(add): fetch dispatch-workflow dependencies and resources when adding remote workflows #19965 — added extractDispatchWorkflowNames to remote_workflow.go

---

Automated by Code Simplifier Agent — analysing code from the last 24 hours

Generated by Code Simplifier · ◷

• expires on Mar 9, 2026, 7:00 PM UTC

[pelikhan]

@copilot recompile

[Copilot]

@copilot recompile

Ran make recompile — all 166 workflow files compiled successfully with no changes to the lock files (they were already up to date).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/graphql
  • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
• https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
  • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha (http block)
• https://api.github.com/repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb
  • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb --jq .object.sha (http block)
• https://api.github.com/repos/githubnext/agentics/git/ref/tags/
  • Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)