[ca] fix: update golden files for awf v0.25.6 and mcpg v0.2.11#23846
Merged
[ca] fix: update golden files for awf v0.25.6 and mcpg v0.2.11#23846
Conversation
Update test golden files to match new default versions: - DefaultFirewallVersion: v0.25.5 → v0.25.6 - DefaultMCPGatewayVersion: v0.2.10 → v0.2.11 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates wasm golden test fixtures to match recently bumped default component versions (AWF and MCP Gateway), unblocking failing CI golden tests.
Changes:
- Bump expected
GH_AW_INFO_AWF_VERSIONin golden outputs fromv0.25.5→v0.25.6 - Update AWF install step and firewall image tags from
0.25.5→0.25.6in golden outputs - Update MCP Gateway image/tag references from
v0.2.10→v0.2.11in golden outputs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden | Updates expected workflow render output to new AWF and MCP Gateway versions. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden | Same golden version updates for the “with-imports” fixture output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure on main branch (run #23833753721).
Root Cause
The
TestWasmGolden_CompileFixturestests were failing because two version constants were bumped inpkg/constants/constants.gobut the corresponding golden test files weren't updated:DefaultFirewallVersion:v0.25.5→v0.25.6DefaultMCPGatewayVersion:v0.2.10→v0.2.11Changes
Updated golden files for the failing test cases:
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.goldenpkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.goldenEach file had 5 occurrences of the old versions updated to the new values.
Validation
make fmt— passesmake test-unit— all tests pass (includingTestWasmGolden_CompileFixtures/basic-copilotandTestWasmGolden_CompileFixtures/with-imports)make recompile— 179/179 workflows compiled successfully