Skip to content

test: remove 3 vacuous field-storage tests in compile/ir/env.rs #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 1 commit into from
Jul 31, 2026
Merged

test: remove 3 vacuous field-storage tests in compile/ir/env.rs #1726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions src/compile/ir/env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ impl EnvValue {
#[cfg(test)]
mod tests {
use super::*;
use crate::compile::ir::ids::StepId;

#[test]
fn ado_macro_accepts_allowlisted() {
Expand All @@ -275,64 +274,4 @@ mod tests {
assert!(msg.contains("not in ALLOWED_ADO_MACROS"));
}

#[test]
fn coalesce_carries_typed_children() {
let step = StepId::new("synthPr").unwrap();
let v = EnvValue::coalesce(vec![
EnvValue::ado_macro("System.PullRequest.PullRequestId").unwrap(),
EnvValue::step_output(OutputRef::new(step.clone(), "AW_SYNTHETIC_PR_ID")),
]);
match v {
EnvValue::Coalesce(parts) => {
assert_eq!(parts.len(), 2);
assert_eq!(
parts[0],
EnvValue::AdoMacro("System.PullRequest.PullRequestId"),
"first child must be the AdoMacro"
);
assert_eq!(
parts[1],
EnvValue::StepOutput(OutputRef::new(step, "AW_SYNTHETIC_PR_ID")),
"second child must be the StepOutput"
);
}
_ => panic!("expected Coalesce"),
}
}

#[test]
fn concat_carries_typed_children() {
let step = StepId::new("synthPr").unwrap();
let v = EnvValue::concat(vec![
EnvValue::ado_macro("System.PullRequest.PullRequestId").unwrap(),
EnvValue::step_output(OutputRef::new(step.clone(), "AW_SYNTHETIC_PR_ID")),
]);
match v {
EnvValue::Concat(parts) => {
assert_eq!(parts.len(), 2);
assert_eq!(
parts[0],
EnvValue::AdoMacro("System.PullRequest.PullRequestId"),
"first child must be the AdoMacro"
);
assert_eq!(
parts[1],
EnvValue::StepOutput(OutputRef::new(step, "AW_SYNTHETIC_PR_ID")),
"second child must be the StepOutput"
);
}
_ => panic!("expected Concat"),
}
}

#[test]
fn runtime_expression_stores_body_verbatim() {
let v = EnvValue::runtime_expression("coalesce(dependencies.Agent.result, '')");
match v {
EnvValue::RuntimeExpression(body) => {
assert_eq!(body, "coalesce(dependencies.Agent.result, '')");
}
_ => panic!("expected RuntimeExpression"),
}
}
}