docs(site): fix job/stage targets — dependsOn and condition must be parameters#830
Merged
jamesadevine merged 1 commit intoJun 2, 2026
Conversation
…arameters ADO's template call-site schema only allows template: and parameters: as top-level keys. The previous stage usage example showed bare dependsOn: and condition: keys, and the prose claimed ADO natively supports them — both incorrect. Fixed both targets to show the correct parameters: wrapper, added Notes sections with ADO schema constraints, pool default, and Setup-job list requirement for job target. Added a second Aside callout reinforcing the parameters requirement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
jamesadevine
approved these changes
Jun 2, 2026
jamesadevine
deleted the
docs/fix-targets-template-parameters-97688fc910cfefe0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targets.mdx: thestageusage example showed baredependsOn:andcondition:keys on the- template:line, which ADO's YAML parser rejects. The prose even claimed "ADO natively supportsdependsOnandconditionat the template call site — no template parameters are needed", which is wrong.jobandstageusage examples now show the correctparameters:wrapper.dependsOnlist requirement for agents with a Setup job, andconditionANDing behaviour.<Aside>callout in the Template Target Considerations section to reinforce theparameters:requirement for users who scan to the bottom.->arrow inconsistency instandaloneand1esdescriptions.Changes
site/src/content/docs/reference/targets.mdx: fixed stage usage example; updated job usage to showparameters:; added Notes sections; fixed arrow characters; added Aside callout.Accuracy checks
docs/targets.md(canonical source of truth).template:+parameters:only) confirmed indocs/targets.mdnotes for bothjobandstagetargets.vmImage: ubuntu-22.04) confirmed indocs/targets.md.Validation
cd site && npm ci && npm run buildCreated by the docs-writer workflow.