test: remove 2 duplicate tests in safeoutputs#833
Merged
jamesadevine merged 1 commit intoJun 2, 2026
Conversation
…t_on_work_item - add_pr_comment: test_allowed_statuses_case_insensitive_reverse is a symmetric duplicate of test_allowed_statuses_case_insensitive_match. eq_ignore_ascii_case is definitionally symmetric so testing the reverse direction adds no coverage. - comment_on_work_item: test_config_partial_deserialize_uses_defaults has an identical body to test_config_deserializes_from_yaml (same YAML input, same assertion). Remove the weaker-named duplicate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Suite Reduction:
src/safeoutputs/What was wrong
test_allowed_statuses_case_insensitive_reverse(add_pr_comment.rs): a symmetric duplicate oftest_allowed_statuses_case_insensitive_match. Both tests inline the sameeq_ignore_ascii_casecomparison snippet — one with config"Active"/ status"active", the other with config"active"/ status"Active". Becauseeq_ignore_ascii_caseis definitionally symmetric, the reverse test adds no coverage.test_config_partial_deserialize_uses_defaults(comment_on_work_item.rs): identical body totest_config_deserializes_from_yaml— same YAML (target: "*"), same assertion (config.target.is_some()). The name claims it tests defaults but it does not exercise any default value.Changes
test_allowed_statuses_case_insensitive_reverseadd_pr_comment.rstest_allowed_statuses_case_insensitive_matchtest_config_partial_deserialize_uses_defaultscomment_on_work_item.rstest_config_deserializes_from_yamlVerification
cargo test: all tests pass ✅cargo clippy --all-targets --all-features: no errors ✅Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comspsprodweu4.vssps.visualstudio.comSee Network Configuration for more information.