Skip to content

test: remove 2 duplicate tests in safeoutputs#833

Merged
jamesadevine merged 1 commit into
mainfrom
test-reducer/safeoutputs-duplicates-19dc4b2c69218d82
Jun 2, 2026
Merged

test: remove 2 duplicate tests in safeoutputs#833
jamesadevine merged 1 commit into
mainfrom
test-reducer/safeoutputs-duplicates-19dc4b2c69218d82

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jun 2, 2026

Test Suite Reduction: src/safeoutputs/

What was wrong

  • test_allowed_statuses_case_insensitive_reverse (add_pr_comment.rs): a symmetric duplicate of test_allowed_statuses_case_insensitive_match. Both tests inline the same eq_ignore_ascii_case comparison snippet — one with config "Active" / status "active", the other with config "active" / status "Active". Because eq_ignore_ascii_case is definitionally symmetric, the reverse test adds no coverage.

  • test_config_partial_deserialize_uses_defaults (comment_on_work_item.rs): identical body to test_config_deserializes_from_yaml — same YAML (target: "*"), same assertion (config.target.is_some()). The name claims it tests defaults but it does not exercise any default value.

Changes

Test File Action Reason
test_allowed_statuses_case_insensitive_reverse add_pr_comment.rs Removed Symmetric duplicate of test_allowed_statuses_case_insensitive_match
test_config_partial_deserialize_uses_defaults comment_on_work_item.rs Removed Identical body to test_config_deserializes_from_yaml

Verification

  • cargo test: all tests pass ✅
  • cargo clippy --all-targets --all-features: no errors ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • spsprodeus21.vssps.visualstudio.com
  • spsprodweu4.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"
    - "spsprodweu4.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Test Reducer · sonnet46 1.9M ·

…t_on_work_item

- add_pr_comment: test_allowed_statuses_case_insensitive_reverse is a
  symmetric duplicate of test_allowed_statuses_case_insensitive_match.
  eq_ignore_ascii_case is definitionally symmetric so testing the
  reverse direction adds no coverage.
- comment_on_work_item: test_config_partial_deserialize_uses_defaults
  has an identical body to test_config_deserializes_from_yaml (same
  YAML input, same assertion). Remove the weaker-named duplicate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine jamesadevine marked this pull request as ready for review June 2, 2026 23:39
@jamesadevine jamesadevine merged commit 18c5f77 into main Jun 2, 2026
@jamesadevine jamesadevine deleted the test-reducer/safeoutputs-duplicates-19dc4b2c69218d82 branch June 2, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant