Repository navigation
Use retained Local storage and verify delivery capabilities for isolated v3 benchmarks - #201
Conversation
…ted v3 benchmarks The isolated v3 campaign inherited the storage-only sample S3 backend, whose current complete retained-version contract cannot support cold RAW/CHUNK and full hydration. Configure the owned Local object store beneath each backend service-data root, retain the same isolated dependency ownership and cleanup, and reject oversized, malformed or missing required delivery capabilities before seed and measurement. Existing startup and cleanup assertions remain; new tests require exact Local config and capability rejection with cleanup ownership. Local Python workspace gates: 182 passed, 30 platform-dependent skipped (212 total), with complete raw log. Capability HTTP header and body reads run in an owned child with absolute deadline and reserved termination/reaping time; readiness retries preserve the original deadline. No native deployment, server database run or large-scale performance result is claimed.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a0b8b85fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| or type(capabilities.get("protocol_versions")) is not list | ||
| or not any(type(version) is int and version == 2 | ||
| for version in capabilities["protocol_versions"])): |
There was a problem hiding this comment.
When a server advertises the required feature booleans and includes version 2 alongside another version, this gate succeeds even if metadata_codecs, frame_encodings, or limits are missing or malformed. Both fixed benchmark clients reject such advertisements in src/snapshot/capabilities.rs because they require exactly [2], codec [1], supported frame encodings, and valid canonical limits; the campaign therefore publishes its seed before failing when the client daemon starts. Validate the same canonical wire contract here so incompatible servers are rejected before seed creation as intended.
Useful? React with 👍 / 👎.
1 participant
The isolated v3 campaign inherited the storage-only sample S3 backend, whose current complete retained-version contract cannot support cold RAW/CHUNK and full hydration. Configure the owned Local object store beneath each backend service-data root, retain the same isolated dependency ownership and cleanup, and reject oversized, malformed or missing required delivery capabilities before seed and measurement. Existing startup and cleanup assertions remain; new tests require exact Local config and capability rejection with cleanup ownership. Local Python workspace gates: 182 passed, 30 platform-dependent skipped (212 total), with complete raw log. Capability HTTP header and body reads run in an owned child with absolute deadline and reserved termination/reaping time; readiness retries preserve the original deadline. No native deployment, server database run or large-scale performance result is claimed.
Validation: independent exact-source review; tracked diff, complete candidate-tree diff passed. New native execution remains pending. No new performance measurement is claimed. The reviewed change retains production checks and existing integrity assertions. Commit has a valid GitHub signature; no force push. Source and necessary tests only; evidence stays outside the repository.