Repository navigation
test(v3): repair budget admission and clock fixtures - #203
Merged
Merged
Conversation
The budget correctness gate stopped before its intended timeout and owned-process cleanup checks because execute now reads profile and paired before the older SimpleNamespace fixtures supplied them. Add medium profile and paired=False to the short-recovery fixture, and paired=False to the shared Linux owned-failure fixture. The second-backend startup failure fixture also used two live wall-clock samples at the exact235-minute ceiling; fix its wall and monotonic clocks while keeping the complete235-minute window and all admitted-owner retirement assertions. Preserve every existing assertion, Linux signal test, production admission check and budget. Windows budget, benchmark, projection, affected campaign case and complete workspace Python gates pass; the actual Linux process and signal tests retain their existing platform skips and require Linux CI verification.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark correctness gate failed before reaching its timeout and owned-process cleanup assertions because the fixtures omitted the
profileandpairedfields read by admission. Supply those fields and use fixed clocks for the second-backend startup failure fixture at the 235-minute boundary.All existing assertions, Linux process and signal tests, production budgets, admission checks and workflows are preserved. Only two test files change.
Validation: Linux benchmark correctness run 37744492291 passed all 303 tests (72 commit-update tests and 231 workspace tests), with zero failures or skips; all six affected cases executed successfully, and Python compilation passed. Independent source and native evidence reviews passed. The signed commit and squash merge contain the reviewed tree. No large performance test was run.