feat: use unique OAuth callback path for glean-cli#82
Merged
steve-calvert-glean merged 1 commit intomainfrom Apr 9, 2026
Merged
feat: use unique OAuth callback path for glean-cli#82steve-calvert-glean merged 1 commit intomainfrom
steve-calvert-glean merged 1 commit intomainfrom
Conversation
Make the OAuth redirect URI callback path more specific by changing it from /callback to /glean-cli-callback. This distinguishes glean-cli from other clients that use very similar redirect URI patterns in the trusted dynamic client registry.
steve-calvert-glean
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OAuth redirect URI callback path is changed from
/callbackto/glean-cli-callbackso that glean-cli's trusted client entry can be matched more definitively. Several other clients use very similar127.0.0.1:*/callbackpatterns in the trusted dynamic client registry, making it hard to distinguish them; a client-specific path eliminates the ambiguity.