DirectTCPIPHandler: block until copying is done or fails#128
Open
stapelberg wants to merge 1 commit intogliderlabs:masterfrom
Open
DirectTCPIPHandler: block until copying is done or fails#128stapelberg wants to merge 1 commit intogliderlabs:masterfrom
stapelberg wants to merge 1 commit intogliderlabs:masterfrom
Conversation
This way, users can wrap DirectTCPIPHandler with behavior, e.g. waking up a powered-down machine before proxying packets to it, and sending that machine back to sleep once no more connections are open. AFAICT, this is not a change in behavior since handlers are already run in their own goroutine, so blocking in DirectTCPIPHandler should not block anything: https://github.com/gliderlabs/ssh/blob/59d6e4540dea33ecd8f90b12887906b7b081fbcd/server.go#L287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, users can wrap DirectTCPIPHandler with behavior, e.g. waking up a
powered-down machine before proxying packets to it, and sending that machine
back to sleep once no more connections are open.
AFAICT, this is not a change in behavior since handlers are already run in their
own goroutine, so blocking in DirectTCPIPHandler should not block anything:
ssh/server.go
Line 287 in 59d6e45