build: add uninstall-local for the install-data-local files - #4784
Merged
amarts merged 1 commit intoSep 23, 2026
Merged
Conversation
extras/Makefile.am installs the glusterd group-profile files (and, with --with-tmpfilesdir, the tmpfiles config) via a custom install-data-local hook. Automake generates no uninstall rule for install-*-local hooks, so "make uninstall" left 7 files under $(GLUSTERD_WORKDIR)/groups/ behind. Add a matching uninstall-local (same tmpfilesdir/WITH_SERVER conditions); build-verified install+uninstall now leaves 0 residual files (was 7). Fixes: gluster#4783 Signed-off-by: Thales Antunes de Oliveira Barretto <thales.barretto.git@gmail.com>
amarts
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4783
extras/Makefile.aminstalls the glusterd group profiles (and, with--with-tmpfilesdir, the tmpfiles config) via a custominstall-data-localhook. Automake generates no uninstall rule for
install-*-local, somake uninstallleft 7 files under$(GLUSTERD_WORKDIR)/groups/behind.Add an
uninstall-localmirroringinstall-data-local(sametmpfilesdir/WITH_SERVERconditions):rm -fthe seven group files and thetmpfiles conf, then
rmdirthe emptygroups/. +15 lines,extras/Makefile.amonly; install is unchanged.Build-proven A/B (Debian trixie): residual after
make uninstall7 → 0.Build-system only; no runtime code touched.