Skip to content

refactor: extract helper functions from SearchIssues #36158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bimakw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: extract helper functions from SearchIssues #36158

bimakw wants to merge 2 commits into from
+93 −81

Conversation

@bimakw
Copy link

@bimakw bimakw commented Dec 14, 2025

Summary

This PR refactors the SearchIssues function in routers/api/v1/repo/issue.go by extracting common logic into reusable helper functions:

  • parseIssueIsClosed(): Parses the "state" query parameter and returns the corresponding isClosed option
  • parseIssueIsPull(): Parses the "type" query parameter and returns the corresponding isPull option
  • buildSearchIssuesRepoIDs(): Builds the list of repository IDs for issue search based on query parameters

Benefits:

  • Improved code readability
  • Smaller, more focused functions
  • Easier to test individual components
  • Potential for reuse in other handlers

Changes:

  • Extracted 3 helper functions from the ~292 line SearchIssues function
  • No functional changes - behavior remains the same
  • Proper error handling preserved

Test plan

  • Verify existing API tests pass
  • Manual testing of /repos/issues/search endpoint

Ref: #35015

@bimakw
refactor: extract helper functions from SearchIssues
2aeb966 
Split the SearchIssues function into smaller, more maintainable pieces:

- parseIssueIsClosed: parses "state" query parameter
- parseIssueIsPull: parses "type" query parameter
- buildSearchIssuesRepoIDs: builds repository IDs list for search

This improves code readability and makes the logic easier to test
and reuse.

Ref: go-gitea#35015
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 14, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 14, 2025
@bimakw
fix: use errors.New instead of fmt.Errorf for static string
e04b0bd 
Replace fmt.Errorf with errors.New for better performance as suggested
by perfsprint linter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bimakw @GiteaBot