Skip to content

tests: gate remote flatten fixtures as long tests #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HNO3Miracle wants to merge 1 commit into from
+4 −0
Closed

tests: gate remote flatten fixtures as long tests #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions flatten_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,10 @@ func TestFlatten_1851(t *testing.T) {
}

func TestFlatten_RemoteAbsolute(t *testing.T) {
if !antest.LongTestsEnabled() {

@fredbi fredbi Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the test is not desirable, and I disagree with weakening the test suite.

What is needed instead to really improve this test is to serve the entire spec locally (e.g. with a httptest server like you've seen in your "go-openapi/validate" PR). But the fixture needs some tweaking to resolve remotes against a localhost test server.

t.Skip("requires remote fixtures; use -enable-long to run")
}

for _, toPin := range []string{
// this one has simple remote ref pattern
filepath.Join("fixtures", "bugs", "remote-absolute", "swagger-mini.json"),
Expand Down
Loading