Fix: Angular contacts lookup example #387
Conversation
| "help", | ||
| "home", | ||
| "info", | ||
| "link", |
There was a problem hiding this comment.
We can't add this here, because it is inconsistent with the specification in https://github.com/google/A2UI/blob/main/specification/0.8/json/standard_catalog_definition.json
Can we make do without the link icon?
It's a pretty reasonable feature request to add support for this in a future spec version though!!
There was a problem hiding this comment.
Thanks for sharing the reason here.
I can update the code to remove it for now to keep the PR clean. Makes sense.
There was a problem hiding this comment.
@jacobsimionato , @crisbeto I've updated the PR to remove the usage of the link icon
There was a problem hiding this comment.
Thanks! I'll let @crisbeto review from here because he knows the Angular codebase much better than me
…tion context and UI for contact lookup sample
AhsanAyaz
force-pushed
the
fix/angular-contacts-demo-example
branch
from
a29d374 to
274116f
Compare
| protected readonly resolvedName = computed(() => this.resolvePrimitive(this.name())); | ||
| protected readonly resolvedName = computed(() => { | ||
| const name = this.resolvePrimitive(this.name()); | ||
| return name ? name.replace(/[A-Z]/g, (letter) => `_${letter.toLowerCase()}`) : null; |
There was a problem hiding this comment.
This seems off to me. The runtime shouldn't be modifying the icon name, but rather the agent should return the right name to begin with.
There was a problem hiding this comment.
I can look into why that happens in depth. However, it wasn't returning the right name. It was returning locationOn instead of location-on, for example.
3 participants
fix: enhance icon handling, expand contact data, and refine agent action context and UI for contact lookup sample
Fixes #386
Before ❌:
Contact Card
Upon following contact
Messaging contact
Now ✅
Contact Card
Following contact
Messaging contact