Skip to content

Conversation

@zoulx-0717
Copy link

A2UI Vue 2 Renderer - Render A2UI components using Vue 2.6 with Options API

Copy link
Collaborator

@paullewis paullewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, thank you for this huge contribution. I've left a couple of notes, but they apply across the PR and boil down to:

  1. Can we remove (this as any) and match the base types more closely?
  2. Can we align the styles to the Angular/Lit implementations? There seem to be some styles applied per component that aren't exactly the same, e.g., the divider.

Again, thank you for the PR!


if (!target || !path) return;

(this as any).setData(path, target.checked);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to type this more cleanly than dropping to an any?

flex: var(--weight);
margin: 0;
border: none;
background-color: currentColor;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these styles differ from the Angular/Lit counterparts. Can we align them?

@zoulx-0717
Copy link
Author

zoulx-0717 commented Jan 6, 2026 via email

@zoulx-0717 zoulx-0717 requested a review from paullewis January 9, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants