Conversation
|
Thanks for re-sending this! We will figure out a way to get it merged. |
|
Amazing work! We are longing for this feature. |
|
@haohaozaici I tried to build iand test it but no luck with build do you have any ideas, thanks! |
|
@volser You can add Because I am using cmake to develop and debug, you also need to modify It should be noted that because of my personal reasons, this pull request is developing very slowly, and currently supported scenarios are very limited! |
|
I've been able to get adaptive playback working with this pull request by making some separate changes to |
|
What is the Status here? Half year ago and no Update? |
|
Hi guys. When will this branch be merged? ffmpeg fallback should be a great feature |
|
See #2159 (comment). |
| void CopyPlane(const uint8_t *source, int source_stride, uint8_t *destination, | ||
| int destination_stride, int width, int height) { | ||
| while (height--) { | ||
| std::memcpy(destination, source, width); |
There was a problem hiding this comment.
Sorry if this is the wrong place to put this but,
It seems like CopyPlane needs to take the strides into account when copying data. Something like
std::memcpy(destination, source, std::min(std::min(width, source_stride), destination_stride));
prevents reading past the end of source or writing past the end of destination.
I'm pretty sure this is responsible for the issue reported here #9459
|
Please fix conflicts |
(cherry picked from commit 3e42457)
(cherry picked from commit 3e42457)
(cherry picked from commit 3e42457)
(cherry picked from commit 3e42457)
(cherry picked from commit 3e42457)
For more information, see #7079