This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Adds --log=LEVEL to allow specifying verbosity.#52
Open
dlzr wants to merge 1 commit intogoogle:masterfrom
Open
Adds --log=LEVEL to allow specifying verbosity.#52dlzr wants to merge 1 commit intogoogle:masterfrom
dlzr wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
I need to run adb-sync from a cronjob, and any output from the command will generate an email. I need it to only print output in case something went wrong, to minimize the number of spurious emails.
adbitself writes its normal chatter to stdout, which I redirect to/dev/null, and only error messages end up in stderr, as expected.adb-syncuses python'slogginglibrary, which seems to write everything to stderr, regardless of severity, which makes it hard to only silence the benign verbosity.So, this PR adds a --log flag, to make it possible to silence the "everything is fine, just doing my job" messages, while leaving the serious stuff on. I've set it up to default to INFO, which is what the current code is doing.
I've already signed the CLA.