Conversation
javanlacerda
force-pushed
the
javan.fix.handle_tuple
branch
from
6064d67 to
9732f68
Compare
decoNR
reviewed
Feb 9, 2026
Contributor
decoNR
left a comment
decoNR
left a comment
There was a problem hiding this comment.
Nice that you have added tests, thanks!
| 'clusterfuzz._internal.platforms.android.settings.get_build_product', | ||
| ]) | ||
|
|
||
| def test_default(self): |
Contributor
There was a problem hiding this comment.
This and the following tests are missing doc strings, please add it to them.
| return _get_prefix_and_full_hash(android_kernel_repo_data, | ||
| kernel_partial_hash) | ||
|
|
||
| return None, None |
Contributor
There was a problem hiding this comment.
Do you know why here is returned None, None and line 117 returns None?
Collaborator
Author
There was a problem hiding this comment.
It is a bug, definitely.
decoNR
approved these changes
Feb 9, 2026
Contributor
|
Please fix check Run basic tests / build (pull_request). |
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
javanlacerda
force-pushed
the
javan.fix.handle_tuple
branch
from
9732f68 to
091447b
Compare
|
Okey but it's just Planning my whole android System and also Right Now my
Mobile Is fully no Perfect Understanding By Using My Side (Resources Are
Fully Dispatched) so Right Now I am finding My correct Address/ and
Maintain my All important Docu and Existing Collection the Mistake also ..(
Or main Thing Is Working Or Automatically Generate integrate Was
Vaulnarable ( Raw ) citations Is scary As My Experience So I am Right now
so Secure And Not Setup again Did Mistake.(Own personal hand 💌'If
grammarly mistake then Sorry 🙂
Shakib
…On Tue, 10 Feb 2026, 22:33 Javan Lacerda, ***@***.***> wrote:
Merged #5159 <#5159> into
master.
—
Reply to this email directly, view it on GitHub
<#5159 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/B332O6OSWYZNN7232TVPYKT4LIB4ZAVCNFSM6AAAAACUQYI5DOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSGY3TSNJZHA2DGOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
ViniciustCosta
pushed a commit
that referenced
this pull request
Feb 18, 2026
fix b/482257453 Update get_kernel_hash_and_build_id to return a tuple with None, None if the match fails. It avoids to have `TypeError: cannot unpack non-iterable NoneType object`. It also create unit tests for src/clusterfuzz/_internal/platforms/android/kernel_utils.py. --------- Signed-off-by: Javan Lacerda <javanlacerda@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix b/482257453
Update get_kernel_hash_and_build_id to return a tuple with None, None if the match fails. It avoids to have
TypeError: cannot unpack non-iterable NoneType object.It also create unit tests for src/clusterfuzz/_internal/platforms/android/kernel_utils.py.