Fix incorrect gdp_sigma for one-way marginals in MST mechanism#22
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix incorrect gdp_sigma for one-way marginals in MST mechanism#22copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The one-way marginal measurement was passing raw zCDP rho directly as gdp_sigma to measure_marginals_with_noise, instead of first converting it to a Gaussian sigma via accounting.zcdp_gaussian_sigma(). This is now consistent with the two-way marginals code path which already performed the conversion correctly. PiperOrigin-RevId: 932847857
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect gdp_sigma for one-way marginals in MST mechanism
The one-way marginal measurement was passing raw zCDP rho directly as
gdp_sigma to measure_marginals_with_noise, instead of first converting
it to a Gaussian sigma via accounting.zcdp_gaussian_sigma(). This is
now consistent with the two-way marginals code path which already
performed the conversion correctly.