Add split and key methods to RngStream and Rngs#5047
Open
samanklesaria wants to merge 4 commits intogoogle:mainfrom
Open
Add split and key methods to RngStream and Rngs#5047samanklesaria wants to merge 4 commits intogoogle:mainfrom
samanklesaria wants to merge 4 commits intogoogle:mainfrom
Conversation
Collaborator
Author
|
Unfortunately, the |
3223d3e to
aa6ce6a
Compare
aa6ce6a to
b63c831
Compare
b63c831 to
6656042
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
0e76365 to
0804444
Compare
cgarciae
approved these changes
Oct 30, 2025
Collaborator
|
Thanks @samanklesaria ! As a follow up PR, we could consider:
|
cgarciae
reviewed
Nov 12, 2025
| return pad_shard_unpad_wrapper | ||
|
|
||
|
|
||
| class _DictOrList(dict): |
Collaborator
Author
There was a problem hiding this comment.
It's a utility datatype used by build_tree_from_paths, which is an inverse of jax.tree.leaves_with_path. It's useful for defining the bridge code porting old rng state to the new names. See the changes to the tutorial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5046