refactor: Fix parameters in method endpoints

[alexandear]

This PR adds the paramcheck custom linter that detects issues with body and query parameters. Changes are non-breaking.

The paramcheck does the following:

• suggests renaming a body parameter to body
• reports body parameters passed by pointer, because body parameters are usually required
• reports body parameter types with an Options suffix, because Options are used for query parameters
• suggests renaming a query struct to opts
• reports query parameter passed by value, because query parameters are usually optional
• reports query parameter types without an Options suffix

[codecov]

Codecov Report

❌ Patch coverage is 99.43182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.47%. Comparing base (0eacd34) to head (b2ad890).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
github/codespaces_secrets.go	85.71%	0 Missing and 2 partials ⚠️
github/git_refs.go	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4300   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         192      192           
  Lines       19310    19310           
=======================================
  Hits        18822    18822           
  Misses        270      270           
  Partials      218      218           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmlewis]

I'm wondering if we should standardize on an "Options" suffix for query (URL) parameters at the same time since we are standardizing on a "Request" suffix for body parameters?

If so, it seems to me like this new linter is the perfect place to put this.

Thoughts?

[alexandear]

I'm wondering if we should standardize on an "Options" suffix for query (URL) parameters at the same time since we are standardizing on a "Request" suffix for body parameters?

If so, it seems to me like this new linter is the perfect place to put this.

Thoughts?

Agree, good idea. I'll extend the linter.
Also should think of a better name for the linter.

[alexandear]

@gmlewis I extended the linter, ready for review.

The linter found a few more problems, created #4301.

[gmlewis]

Thank you, @alexandear!
Two tiny nits, otherwise LGTM.

cc: @stevehipwell - @zyfy29 - @Not-Dhananjay-Mishra