checklocks: guard the TCP segment queue - #14259
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
r? @nybidari for the segment queue field guards and existing helper precondition. Local TCP analysis, unit, and receive tests passed. The broader TCP end-to-end target is blocked here by baseline Linux-only build dependencies on macOS. Assisted-by: Codex |
The segment queue uses mu for its list and frozen state, but checklocks does not enforce that ownership. Guard both fields and enforce the existing caller-held lock requirement of emptyLocked. Assisted-by: Codex
tamird
force-pushed
the
checklocks-tcp-segment-queue
branch
from
August 21, 2026 23:08
6c22efb to
5ef194b
Compare
Contributor
Author
|
Closing in favor of consolidated #14338. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The segment queue uses mu for its list and frozen state, but checklocks does not enforce that ownership. Guard both fields and enforce the existing caller-held lock requirement of emptyLocked.
Assisted-by: Codex