checklocks: enforce UDP receive-state ownership - #14262
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Packet delivery reads frozen under rcvMu, but freeze, thaw, and restore write it under mu. Use rcvMu for all accesses and group frozen with the receive state it controls. Annotate the receive fields and reuse thaw after successful restore so checklocks enforces the same ownership during normal operation and save/restore. Assisted-by: Codex
Contributor
Author
|
r? @nybidari for the receive-state guards and freeze/thaw locking correction, including the successful-restore path. Both UDP analysis checks and the runtime suite passed locally. The suite does not exercise save/restore; that path was reviewed from source. Assisted-by: Codex |
Contributor
Author
|
Closing in favor of consolidated #14338. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packet delivery reads frozen under rcvMu, but freeze, thaw, and restore write it under mu. Use rcvMu for all accesses and group frozen with the receive state it controls.
Annotate the receive fields and reuse thaw after successful restore so checklocks enforces the same ownership during normal operation and save/restore.
Assisted-by: Codex